Skip to content

Respect HandleResponse() and SkipHandler() calls in OnResourceMetadataRequest #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

halter73
Copy link
Contributor

@halter73 halter73 commented Jul 9, 2025

This new code handles cases where RequestContext.HandleResponse() and .SkipHandler() get called in the same way other authentication handlers like RemoteAuthenticationHandler do here.

@DavidParks8

@halter73 halter73 requested a review from localden July 9, 2025 22:44
@halter73
Copy link
Contributor Author

The Avoid null dereferencing when authorization_endpoint is missing commit should partially address #604 by at least avoiding the NullReferenceException. I'll submit a seperate PR if we decide to add new APIs to make the scenario work fully, but fixing the null dereferencing seemed simple enough to do immediately.

@halter73 halter73 merged commit f53e0d2 into main Jul 18, 2025
10 checks passed
@halter73 halter73 deleted the halter73/respect-HandleRequestResult branch July 18, 2025 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants