Respect HandleResponse() and SkipHandler() calls in OnResourceMetadataRequest #607
+125
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidParks8
approved these changes
Jul 10, 2025
src/ModelContextProtocol.AspNetCore/Authentication/McpAuthenticationHandler.cs
Show resolved
Hide resolved
|
The Avoid null dereferencing when authorization_endpoint is missing commit should partially address #604 by at least avoiding the NullReferenceException. I'll submit a seperate PR if we decide to add new APIs to make the scenario work fully, but fixing the null dereferencing seemed simple enough to do immediately. |
eiriktsarpalis
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new code handles cases where
RequestContext.HandleResponse()and.SkipHandler()get called in the same way other authentication handlers like RemoteAuthenticationHandler do here.@DavidParks8